Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short url: Embed flag is not respected #72830

Closed
flash1293 opened this issue Jul 22, 2020 · 2 comments
Closed

Short url: Embed flag is not respected #72830

flash1293 opened this issue Jul 22, 2020 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:SharingURLs Short URLs and Share URL features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort regression

Comments

@flash1293
Copy link
Contributor

Kibana version: 7.9 BC2

Describe the bug: iframe short urls created prior to 7.7 lose the embed flag and are thus rendering with visible chrome

Steps to reproduce:

  1. Open Kibana < 7.7
  2. Go to dashboard and create iframe short url (will look like this: /goto/sdhfkjsdfhjklds?embed=true)
  3. Upgrade to Kibana 7.7 or later
  4. Visit short url
  5. Dashboard is rendered with visible chrome

Expected behavior:
Dashboard should render in embedded mode.

Any additional context:

This is happening because this change: #58846
In 7.7 and after the embed flag is part of the saved short URL. While this behavior makes sense, it didn't take into account existing short urls with the embed flag outside of the url saved object.

This can be fixed by checking whether there is a embed flag in the server side short url redirect handling and including it into the redirected url.

@flash1293 flash1293 added bug Fixes for quality problems that affect the customer experience regression Feature:SharingURLs Short URLs and Share URL features Team:AppArch labels Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort triaged labels Feb 24, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jun 21, 2021
@ppisljar
Copy link
Member

ppisljar commented Aug 8, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as completed Aug 8, 2022
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:SharingURLs Short URLs and Share URL features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort regression
Projects
None yet
Development

No branches or pull requests

4 participants