Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design for Solution Grouping on Spaces and Roles Pages #72659

Open
MichaelMarcialis opened this issue Jul 21, 2020 · 7 comments
Open

Design for Solution Grouping on Spaces and Roles Pages #72659

MichaelMarcialis opened this issue Jul 21, 2020 · 7 comments
Assignees
Labels
design loe:medium Medium Level of Effort REASSIGN from Team:Core UI Deprecated label for old Core UI team

Comments

@MichaelMarcialis
Copy link
Contributor

MichaelMarcialis commented Jul 21, 2020

Based on early design enhancements suggested by the Core UI team for the Space page (as part of the customizable banner feature design), @legrego has begun implementing the suggested grouping of features/plugins by parent solution. He has requested additional design support to further flesh out this concept to:

  • Account for situations where all child features/plugins are not set to the same visibility setting and the solution accordion is closed.
    • Currently, just the solution-level toggle would be visible, which may lead to some confusion, as it could be toggled on, while some child features/plugins within could be toggled off.
  • Provide a similar solution grouping design for the Role space privileges flyout.
    • The solution-level action may be trickier to implement here, as it is not a binary state. Rather, the All/Read/None options may demand either a fourth "Custom" action or no solution-level action at all, to account for child feature/plugin states.

The desire is to get these changes in the 7.10 Kibana release.

image

@MichaelMarcialis MichaelMarcialis self-assigned this Jul 21, 2020
@MichaelMarcialis MichaelMarcialis added design loe:medium Medium Level of Effort REASSIGN from Team:Core UI Deprecated label for old Core UI team labels Jul 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@MichaelMarcialis MichaelMarcialis changed the title Design for Plugin Solution Grouping on Spaces and Roles Pages Design for Solution Grouping on Spaces and Roles Pages Jul 21, 2020
@alexfrancoeur
Copy link

Cross linking: #54793

@myasonik
Copy link
Contributor

myasonik commented Jul 21, 2020

@MichaelMarcialis What are your thoughts on moving away from Switches to Checkboxes?

This would let the top level group ones enter a third state of "some selected".

Screenshot of a checkbox in an indeterminate state

@MichaelMarcialis
Copy link
Contributor Author

@MichaelMarcialis What are your thoughts on moving away from Switches to Checkboxes?

Yeah, that's not a bad idea. I'll play around with that idea in my next round of updates. Thanks!

@legrego
Copy link
Member

legrego commented Aug 3, 2020

@MichaelMarcialis I have a preliminary draft PR up as a starting point for design revisions: #74151

This does not [yet] include the checkboxes that @myasonik proposed

@MichaelMarcialis
Copy link
Contributor Author

@MichaelMarcialis I have a preliminary draft PR up as a starting point for design revisions: #74151

This does not [yet] include the checkboxes that @myasonik proposed

Cool, I'll take a look at the PR. I'm hoping to wrap up my design concepts and review them with you later this week. Stay tuned for a calendar invite.

@MichaelMarcialis
Copy link
Contributor Author

Heya, @legrego! Per our review meeting, I've updated the designs for this issue. These updates include:

  • Changing all references of "Write" back to "All".
  • Changing all references of "Apps" back to "Features".
  • Added example of an updated privilege summary.
  • Restored the ability to define how privileges should be handled for future feature releases (though in a slightly new way than it is handled now; please see Figma notes for details).

Please have a look at the design assets below when you get a moment. I've called out any questions or comments I have via notes below the various art boards in the mockups. Please let me know if these changes address your needs, or if you have any additional questions or feedback. You can leave me comments directly in Figma (via the commenting tool). Alternatively, I would be happy to schedule another review meeting if you feel one is needed. Thanks!

Design Assets

Screenshots

Edit Space

Canvas Unselected

Create Role

Dashboard Read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design loe:medium Medium Level of Effort REASSIGN from Team:Core UI Deprecated label for old Core UI team
Projects
None yet
Development

No branches or pull requests

5 participants