Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Accessibility) Ingest Node Pipelines UI #71666

Open
jloleysens opened this issue Jul 14, 2020 · 3 comments
Open

(Accessibility) Ingest Node Pipelines UI #71666

jloleysens opened this issue Jul 14, 2020 · 3 comments
Labels
Feature:Ingest Node Pipelines Ingest node pipelines management Project:Accessibility Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jloleysens
Copy link
Contributor

jloleysens commented Jul 14, 2020

Steps to reproduce

  1. Start Kibana on basic license
  2. Navigate to the Ingest Node Pipelines application (there should be at least 2 pipelines by default)
  3. Interact with a11y features in the app like opening a pipeline and re-ordering processors

Current list of a11y issues

  1. Use of react-virtualized leading to issue with HTML grid being 0 rows and 0 columns even though there are processors. This makes the HTML not traversable as a grid (react-window is a recommended alternative, matching EUI)
  2. No visual indication of "drop" button on keyboard focus. These are the buttons that you would use to place a processor after entering move mode [Ingest Pipelines] Processors editor a11y focus states #79122
  3. Other elements in the processor should not be focus-able while in move mode. This will provide a much smoother a11y experience [Ingest Pipelines] Processors editor a11y focus states #79122
  4. If the 4th item in a list of processors is moved to the 6th position, focus jumps back to the 4th item in the list. After moving a processors, the moved processor should get focus
  5. In the processor configuration form, the code editor (React monaco) is currently a focus trap
  6. When the duplicate processor action is taken, the newly duplicated processor should get focus
  7. When a new processor is created that processor should get focus or at least the list of processors should get focus
  8. Deleting a processor should focus the processors list
  9. Differentiate "Add a processor" buttons in their aria-labels. For instance, adding to the global on failure list should have a different aria-label to adding to the primary processors list
  10. When testing processors the "Output" pane is disabled, but the screen reader reports 2 tabs. We should use "aria-described-by" to indicate that the second tab is disabled (when it is disabled)
  11. After saving a pipeline and navigating back to the pipeline list view, focus should be in the flyout (at the moment focus is not on the flyout and the flyout cannot be accessed)
  12. Updated aria-label for drop zone buttons when they are disabled. The label should indicate that the processor cannot be moved here.
  13. There are 3 nested <main> tags on the ingest pages (there should be one)
  14. On the management page, headings jump to h3 but there are not h2 headings

Kibana Version:

Tested on commit b4737e8

CC @myasonik

@jloleysens jloleysens added Project:Accessibility Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Ingest Node Pipelines Ingest node pipelines management labels Jul 14, 2020
@jloleysens jloleysens self-assigned this Jul 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Contributor

It'd be great if we can add some accessibility tests as part of this work.

@alisonelizabeth alisonelizabeth removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 16, 2024
@alisonelizabeth alisonelizabeth added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed needs-team Issues missing a team label labels Sep 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Ingest Node Pipelines Ingest node pipelines management Project:Accessibility Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants