Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RedirectAppLinks component to APM #69817

Closed
smith opened this issue Jun 24, 2020 · 1 comment · Fixed by #74328
Closed

Add RedirectAppLinks component to APM #69817

smith opened this issue Jun 24, 2020 · 1 comment · Fixed by #74328
Assignees
Labels
Team:APM All issues that need APM UI Team support

Comments

@smith
Copy link
Contributor

smith commented Jun 24, 2020

#67595 added the RedirectAppLinks component, which wraps intra-Kibana anchor tags to they redirect properly without causing a full page refresh.

  • Add this to APM at the root of the application
  • Remove unnecessary navigateToApp usage
  • Ensure all intra-Kibana links work without page refreshes where possible
  • Ensure all in-app links continue to work as well.

RedirectAppLinks uses the platform history object (passed through in params.history in renderApp's arguments), so we'll need to complete #65682 before this.

We may also need to add an onClick handler to the breadcrumb routes that calls navigateToUrl. (related Slack thread: https://elastic.slack.com/archives/C5TQ33ND8/p1594906008200700)

@smith smith added the Team:APM All issues that need APM UI Team support label Jun 24, 2020
@smith smith self-assigned this Jun 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants