Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/optimizer] Remove usage of extraPublicDir #69461

Closed
spalger opened this issue Jun 17, 2020 · 3 comments
Closed

[kbn/optimizer] Remove usage of extraPublicDir #69461

spalger opened this issue Jun 17, 2020 · 3 comments
Labels
Team:Operations Team label for Operations Team v8.0.0

Comments

@spalger
Copy link
Contributor

spalger commented Jun 17, 2020

In #68986 we added the ability to export more than just the public dir of a plugin via the extraPublicDir config in kibana.json. This was intended as a temporary solution until we no longer need to export more than public and could automatically export common. In the meantime we can probably work towards this by removing extraPublicDir where possible and adding a uiCommon flag or something to specifically activate sharing of the common dir.

There are a couple intricacies with this though:

  1. not all common dirs are intended for public use
  2. not all common dirs can be imported in the browser as-is. In some cases the common dir stored config schemas that can be imported by the browser as long as only the types are consumed, consuming the whole schema throws errors as the version of Joi we use is not compatible with the browser.
@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 labels Jun 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@joshdover
Copy link
Contributor

Related to #59710

@tylersmalley tylersmalley added 1 and removed 1 labels Oct 11, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Oct 12, 2021
@tylersmalley tylersmalley removed loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. EnableJiraSync labels Mar 16, 2022
@tylersmalley
Copy link
Contributor

This will be replaced by #128012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team v8.0.0
Projects
None yet
Development

No branches or pull requests

4 participants