Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Do not use MAP_SAVED_OBJECT_TYPE constant when defining URL paths #69400

Closed
nreese opened this issue Jun 17, 2020 · 1 comment · Fixed by #69723
Closed

[Maps] Do not use MAP_SAVED_OBJECT_TYPE constant when defining URL paths #69400

nreese opened this issue Jun 17, 2020 · 1 comment · Fixed by #69723
Assignees
@nreese
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation

Comments

@nreese
Copy link
Contributor

nreese commented Jun 17, 2020 •
edited
Loading

The constant MAP_SAVED_OBJECT_TYPE is being used for multiple meanings

  1. saved object type
  2. defining the path of a route at https://github.com/elastic/kibana/blob/master/x-pack/plugins/maps/public/maps_vis_type_alias.js#L31 and https://github.com/elastic/kibana/blob/master/x-pack/plugins/maps/common/constants.ts#L35

Even though both uses use the same string, they are not the same concepts and MAP_SAVED_OBJECT_TYPE should be split into two constants to clearly define the concepts for each value.
@nreese nreese added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Jun 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck changed the title Do not use MAP_SAVED_OBJECT_TYPE constant when defining URL paths [Maps] Do not use MAP_SAVED_OBJECT_TYPE constant when defining URL paths Jun 17, 2020
@nreese nreese self-assigned this Jun 23, 2020
@nreese nreese mentioned this issue Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths nreese/kibana
2 participants
@nreese @elasticmachine