Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Line and area stepped curve option #68303

Closed
wylieconlon opened this issue Jun 4, 2020 · 5 comments
Closed

[Lens] Line and area stepped curve option #68303

wylieconlon opened this issue Jun 4, 2020 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

wylieconlon commented Jun 4, 2020

The main remaining type to support is Stepped.


There are some basic curve options that users should be able to select for each line in Lens. This option should be presented for each line series, so that you could mix curve types if you choose to.

However, the number of options available in Elastic charts is higher than what we should support.

In the Visualize line chart, we support three options only:

  • Linear
  • Smooth
  • Stepped (equivalent to Step after)

Of the curve options that are available with a demo here, we should support these:

Curve type Special logic
Linear Default
Curve natural
Curve catmull rom
Curve step after Should hide the point
Curve step before Should hide the point

This leaves the following curve types unsupported:

  • Monotone X
  • Monotone Y
  • Basis
  • Step
  • Cardinal

cc @markov00

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon changed the title [Lens] Line charts should support curve options [Lens] Line and area charts should support curve options Jun 4, 2020
@markov00
Copy link
Member

Elastic-charts has already all these curve types for LineSeries and AreaSeries see https://elastic.github.io/elastic-charts/?path=/story/line-chart--curved-with-axis-and-legend

@flash1293 flash1293 added the enhancement New value added to drive a business result label Aug 6, 2020
@wylieconlon
Copy link
Contributor Author

The main remaining type to support is Stepped.

@ghudgins ghudgins changed the title [Lens] Line and area charts should support curve options [Lens] Line and area stepped curve option Aug 31, 2021
@ghudgins
Copy link
Contributor

ghudgins commented Aug 31, 2021

stepped would be an additional option and require us to change the curve from an on/off to a dropdown - https://github.com/elastic/elastic-charts/blob/master/storybook/stories/area/20_stepped_area.tsx#L435

@markov00
Copy link
Member

markov00 commented May 3, 2023

closing in favour of #154410

@markov00 markov00 closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants