[Filters] Support geospatial fields

[AlonaNadler]

Describe the feature:

Elasticsearch supports geo-bounding box, geo-distance, geo-polygon, and geo-shape. It would be nice if we could use these types of filters from the filter bar.

Original notes:

The customer would like to be able to filter on the existence of a geoip fields.

On 7.x versions, it seems greyed out.

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[nreese]

@elastic/kibana-app-arch

Exists filtering is disabled for geo_point and geo_shape fields even though exists query is supported in Elasticsearch.

The button is disabled because of the snippet below. How can we turn on filtering for geo_point and geo_shape type?

https://github.com/elastic/kibana/blob/7.8/src/plugins/discover/public/components/table/table_row.tsx#L82

<DocViewTableRowBtnFilterExists
  disabled={!fieldMapping || !fieldMapping.filterable}
  onClick={() => onFilter('_exists_', field, '+')}
  scripted={fieldMapping && fieldMapping.scripted}
/>

[kmartastic]

@nreese did you ever hear back from @elastic/kibana-app-arch on this?

[lizozom]

Enabling geo filtering from discover is as easy as adding filterable to the GEO_POINT type in src/plugins/data/common/kbn_field_types/kbn_field_types_factory.ts.

However, this adds it to the FilterBar which currently doesn't have any UI for editing geo-filters.

I think that given mocks for how geo filter editing should look like, it shouldn't be too hard to implement. (But there are some edge cases there - for example ES doesn't support topleft=bottomright, so we'd have to increase the filter window by some margin, or how do we handle one of filtering).

@nreese do you think some of the UI components from Maps could be reused here?

[nreese]

Enabling geo filtering from discover is as easy as adding filterable to the GEO_POINT type in src/plugins/data/common/kbn_field_types/kbn_field_types_factory.ts.

Are there any other side-effects of enabling filtering for geo_point and geo_shape types?

do you think some of the UI components from Maps could be reused here?

geo_point and geo_shape filters are created from drawing bounding boxes, polygons, or circles on a map. I do not think these could be reused in the filter pill editor unless the filter pill editor displayed a small map to show the filter's location.

[lizozom]

I think you have kind of answered the question yourself: If you allow adding filters from discover, you need to support editing \ displaying them in the filter bar 🤷‍♀️ , which is not trivial.

I guess we could fallback to just showing the DSL?

[nreese]

I think this is the crux of the issue. How do you enable the exists button as described by the issue without turning on filtering for geo_point and geo_shape fields in the filter pill?

[lizozom]

You could say that the only operator supported by this field is exists (This is controlled by adding a fieldTypes array to the exists operator in src/plugins/data/public/ui/filter_bar/filter_editor/lib/filter_operators.ts).

Then when you enable the filterable option, it should behave correctly (might require some minor adjustments in discover).

However, for some reason, the isOneOfOperator and the isNotOneOfOperator also list geo_point and geo_shape as supported field types, so those will be added too, bringing us back to square one.

Bottom line, I think we need to solve the geo filters UI (even if it's just showin the DSL), rather than try allowing only the exists filter.

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[ThomThomson]

Adding this to the Maps Icebox. While this is a needed enhancement, the extra-large size, complexities around implementing a filtering registry, adding geo shapes to the existing filter pills mean that we will be unable to get to this in the near term.

An alternative / more feasible approach to this would see us creating a geospatial control with shape editing in a popover.