Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from hash routing to path routing #67470

Closed
2 of 10 tasks
flash1293 opened this issue May 27, 2020 · 2 comments
Closed
2 of 10 tasks

Switch from hash routing to path routing #67470

flash1293 opened this issue May 27, 2020 · 2 comments
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented May 27, 2020

Currently all Kibana App apps are using hash routing, while the Kibana platform is leveraging path routing. To avoid complexity and instability, all hash routing should eventually be migrated to path routing.

Related: #65968

To make this transition as simple as possible, de-angularization should be completed first. Then react hash router can be replaced by an agnostic router component bound to the scoped history object passed in from the application service.

To make sure legacy links still work, it's important to provide backwards compatibility (forwarding a hash path to the right browser path when Kibana is opened). This can be implemented as a central utility function as part of the kibana_legacy plugin.

Subtasks

Actually cutting over can be approached separately for the individual apps:

  • Discover
  • Visualize
  • Dashboard
  • Lens
  • Graph
@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels May 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula
Copy link
Contributor

This is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants