Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data.search.aggs] Support significant text in AggConfigs #67394

Closed
10 tasks
lukeelmers opened this issue May 26, 2020 · 1 comment · Fixed by #122166
Closed
10 tasks

[data.search.aggs] Support significant text in AggConfigs #67394

lukeelmers opened this issue May 26, 2020 · 1 comment · Fixed by #122166
Labels
enhancement New value added to drive a business result Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@lukeelmers
Copy link
Member

Part of #60126
Blocks #31614

This issue tracks support for significant text aggregations in AggConfigs. Adding this agg type will unblock apps like Visualize and Lens from supporting these aggs in the future.

  • add new agg type
    • create the agg type
    • export an interface for the agg type's params
    • update AggParamsMapping in types.ts
    • register agg type via agg_types.ts
    • unit tests
  • add agg type expression function
    • write the expression function
    • register expression function via agg_types.ts
    • unit tests
@lukeelmers lukeelmers added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) enhancement New value added to drive a business result loe:medium Medium Level of Effort Team:AppArch labels May 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers mentioned this issue May 26, 2020
Closed
82 tasks
@rayafratkina rayafratkina mentioned this issue May 26, 2020
Closed
7 tasks
@exalate-issue-sync exalate-issue-sync bot added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jun 21, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Dec 15, 2021
@Dosant Dosant mentioned this issue Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Significant Text agg to AggConfigs Dosant/kibana
2 participants
@lukeelmers @elasticmachine