Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Dynamic icons only work when the field is also driving another style-property #66434

Closed
thomasneirynck opened this issue May 13, 2020 · 1 comment · Fixed by #66454
Closed

[Maps] Dynamic icons only work when the field is also driving another style-property #66434

thomasneirynck opened this issue May 13, 2020 · 1 comment · Fixed by #66454
Assignees
@thomasneirynck
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation regression v7.8.0 v7.9.0 v8.0.0

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented May 13, 2020 •
edited
Loading

To reproduce:

  1. Create new vector layer with logs sample data
  2. Create dynamic fill color on agent.keyword
  3. Create dynamic icon on agent.keyword -> this works
  4. Select new field for dynamic icon: geo.dest -> this does not work. Icons no longer display
  5. Select new field for dynamic color: geo.dest -> now it works again. Icons display correctly
  6. Change dynamic color to solid color: -> icons break again

An error is being logged to the console on breakage:

:5601/dhb/9007199254740991/bundles/maps.bundle.js:30347 Uncaught TypeError: Cannot read property 'name' of null
    at onFieldChange (:5601/dhb/9007199254740991/bundles/maps.bundle.js:30347)
    at onFieldChange (:5601/dhb/9007199254740991/bundles/maps.bundle.js:28252)
    at EuiComboBox.onRemoveOption (:5601/dhb/9007199254740991/bundles/kbn-ui-shared-deps/[email protected]:67562)
    at EuiComboBox.removeLastOption (:5601/dhb/9007199254740991/bundles/kbn-ui-shared-deps/[email protected]:67292)
    at :5601/dhb/9007199254740991/bundles/kbn-ui-shared-deps/[email protected]:67477
    at HTMLUnknownElement.callCallback (:5601/dhb/9007199254740991/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:306777)
    at Object.invokeGuardedCallbackDev (:5601/dhb/9007199254740991/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:306826)
    at invokeGuardedCallback (:5601/dhb/9007199254740991/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:306881)
    at invokeGuardedCallbackAndCatchFirstError (:5601/dhb/9007199254740991/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:306895)
    at executeDispatch (:5601/dhb/9007199254740991/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:307025)
@thomasneirynck thomasneirynck added bug Fixes for quality problems that affect the customer experience regression v7.7.1 v7.8.0 v7.9.0 [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels May 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck changed the title [Maps] Dynamic icons does not work unless the same property is also driving [Maps] Dynamic icons only work when the field is also driving another style-property May 13, 2020
@thomasneirynck thomasneirynck self-assigned this May 13, 2020
@thomasneirynck thomasneirynck mentioned this issue May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasneirynck thomasneirynck

Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation regression v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Maps] Get number of categories from palette thomasneirynck/kibana
2 participants
@thomasneirynck @elasticmachine