Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Add validation for < 1 values in TLS expiration fields #65381

Closed
andrewvc opened this issue May 5, 2020 · 2 comments · Fixed by #65454
Closed

[Uptime] Add validation for < 1 values in TLS expiration fields #65381

andrewvc opened this issue May 5, 2020 · 2 comments · Fixed by #65454
Assignees
@justinkambic
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.8.0

Comments

@andrewvc
Copy link
Contributor

andrewvc commented May 5, 2020

It is currently possible to use negative values for TLS expiration in uptime. This makes no sense. We should use the form validator code to mark the form as in an error state if the values are < 1 or are non-integers.

image
@andrewvc andrewvc added bug Fixes for quality problems that affect the customer experience [zube]: Ready Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 labels May 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 self-assigned this May 6, 2020
@shahzad31 shahzad31 mentioned this issue May 6, 2020
Merged
@shahzad31 shahzad31 removed their assignment May 26, 2020
@justinkambic justinkambic self-assigned this May 26, 2020
@justinkambic
Copy link
Contributor

I tested this by pasting negative values into the inputs. The page didn't allow me to do it:

image

image

I also verified the API disallowed these values:

image

image

This also makes me think we should have an API test verifying we get 400 errors for input like this.

@justinkambic justinkambic added the test-plan-ok issue has passed test plan label May 26, 2020
@justinkambic justinkambic mentioned this issue May 26, 2020
Open
@zube zube bot removed the [zube]: Done label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinkambic justinkambic

Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Uptime] Settings threshold validation shahzad31/kibana
4 participants
@andrewvc @shahzad31 @elasticmachine @justinkambic