Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Console for concrete dependencies on elasticsearch config #65028

Closed
cjcenizal opened this issue May 3, 2020 · 3 comments
Closed

Audit Console for concrete dependencies on elasticsearch config #65028

cjcenizal opened this issue May 3, 2020 · 3 comments
Labels
chore Feature:Console Dev Tools Console Feature Feature:Dev Tools Feature:NP Migration Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cjcenizal
Copy link
Contributor

Currently, the legacy Console plugin consumes server.newPlatform.__internals.elasticsearch.legacy.config$ and exports the first emitted value. The NP version of Console consumes this value (a config object) and consumes it internally. We need to audit the specific dependencies upon this config object to help the Platform team provide a NP alternative.

@cjcenizal cjcenizal added chore Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:NP Migration labels May 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jloleysens
Copy link
Contributor

jloleysens commented May 4, 2020

The values required by Console from the legacy are the diff between what we get from:

ESConfigForProxy (src/plugins/console/server/types.ts) and SharedGlobalConfigKeys['elasticsearch'] (src/core/server/plugins/types.ts).

Concretely:

interface ValuesFromLegacy {
  hosts: string[]; // 👈🏻Configured host nodes for Kibana
  // 👇🏻Lower level values used for building the request to be proxied and injecting headers
  requestHeadersWhitelist: string[];
  customHeaders: Record<string, any>;
  ssl?: {
    verificationMode: 'none' | 'certificate' | 'full';
    certificateAuthorities: string[] | string;
    alwaysPresentCertificate: boolean;
    certificate?: string;
    key?: string;
    keyPassphrase?: string;
  };
}

@cjcenizal
Copy link
Contributor Author

Resolved by #75406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Console Dev Tools Console Feature Feature:Dev Tools Feature:NP Migration Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants