-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newsfeed styles are not loaded in the new platform #64996
Comments
Pinging @elastic/kibana-core-ui (Team:Core UI) |
@cchaos any thoughts on how we should handle this one? |
From the technical side - these styles should be moved to the new platform and loaded via |
I think this was built before we were able to release EuiHeaderAlert in EUI and so Kibana's implementation is a shim for the EUI component. But now Kibana has access to EuiHeaderAlert, and should use that one instead of this custom implementation. https://elastic.github.io/eui/#/layout/header (bottom section) |
@flash1293 @cchaos did @afharo 's PR fix this issue too? #66084 |
Actually, in that PR we entirely removed that file because it was replaced by an |
Closed with #66084. |
Kibana version: master
Describe the bug: The newsfeed flyout depends on a few css classes defined here: https://github.com/flash1293/kibana/blob/a50dbefb62edf0be6b98110023afc32b04c06a7f/src/legacy/core_plugins/newsfeed/public/np_ready/components/header_alert/_index.scss
As these styles live in the legacy world and are not imported from within the new platform anywhere, they don't get loaded when only accessing a new platform application (like the logs app).
This problem will get worse once #63443 is merged as it's moving Discover, Visualize and Dashboard to the new platform as well.
The text was updated successfully, but these errors were encountered: