Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsfeed styles are not loaded in the new platform #64996

Closed
flash1293 opened this issue May 1, 2020 · 7 comments · Fixed by #66084
Closed

Newsfeed styles are not loaded in the new platform #64996

flash1293 opened this issue May 1, 2020 · 7 comments · Fixed by #66084
Assignees
Labels
REASSIGN from Team:Core UI Deprecated label for old Core UI team

Comments

@flash1293
Copy link
Contributor

Kibana version: master

Describe the bug: The newsfeed flyout depends on a few css classes defined here: https://github.com/flash1293/kibana/blob/a50dbefb62edf0be6b98110023afc32b04c06a7f/src/legacy/core_plugins/newsfeed/public/np_ready/components/header_alert/_index.scss

As these styles live in the legacy world and are not imported from within the new platform anywhere, they don't get loaded when only accessing a new platform application (like the logs app).

This problem will get worse once #63443 is merged as it's moving Discover, Visualize and Dashboard to the new platform as well.

@flash1293 flash1293 added the REASSIGN from Team:Core UI Deprecated label for old Core UI team label May 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@ryankeairns
Copy link
Contributor

@cchaos any thoughts on how we should handle this one?

@flash1293
Copy link
Contributor Author

flash1293 commented May 8, 2020

From the technical side - these styles should be moved to the new platform and loaded via import in the component using them (indirectly in this case). This is making sure the styles will always be available if the component is around.

@cchaos
Copy link
Contributor

cchaos commented May 8, 2020

I think this was built before we were able to release EuiHeaderAlert in EUI and so Kibana's implementation is a shim for the EUI component. But now Kibana has access to EuiHeaderAlert, and should use that one instead of this custom implementation. https://elastic.github.io/eui/#/layout/header (bottom section)

@ryankeairns
Copy link
Contributor

@flash1293 @cchaos did @afharo 's PR fix this issue too? #66084

@afharo
Copy link
Member

afharo commented May 13, 2020

Actually, in that PR we entirely removed that file because it was replaced by an eui component. The CSS files for that component were setting the exact the same values as the defaults from eui.
I'd say this issue can be closed :)

@afharo afharo linked a pull request May 13, 2020 that will close this issue
1 task
@cqliu1
Copy link
Contributor

cqliu1 commented May 13, 2020

Closed with #66084.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REASSIGN from Team:Core UI Deprecated label for old Core UI team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants