Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics Alerts] Add OUTSIDE RANGE threshold condition #61825

Closed
Zacqary opened this issue Mar 30, 2020 · 8 comments · Fixed by #63993
Closed

[Metrics Alerts] Add OUTSIDE RANGE threshold condition #61825

Zacqary opened this issue Mar 30, 2020 · 8 comments · Fixed by #63993
Labels
Feature:Alerting Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@Zacqary
Copy link
Contributor

Zacqary commented Mar 30, 2020

Design docs for metrics alerts included two additional comparators that we didn't implement in time for 7.7. These are:

  • OUTSIDE RANGE - basically the opposite of BETWEEN, alerts when a value is not between two values
  • IS EMPTY - alerts when the value is zero? @sorantis please clarify
@Zacqary Zacqary added Feature:Alerting Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@sorantis
Copy link

My initial proposal was to let the user set IS EMPTY to alert when there are no new data points for the selected metric.

@Zacqary
Copy link
Contributor Author

Zacqary commented Mar 30, 2020

Right now we have an alert state implemented called No Data; this is distinct from an Alert state or an OK state, but as of right now it's just stored as a state value and doesn't send any messages out. The intention is that we'd eventually reveal this through the alert management/history UI.

Should we just have alerts send a message when they hit a No Data state instead of making this a distinct operator? For example, if we create an alert that's supposed to fire when a metric goes above 1.0, and then that metric suddenly stops reporting, that might indicate some kind of infrastructure failure that the user might want to know about.

@sorantis
Copy link

Ah, you mean like having an option on the Alert dialog?

  • Alert me if there's no data

@Zacqary
Copy link
Contributor Author

Zacqary commented Mar 30, 2020

That could work! Should it be checked by default?

@sorantis
Copy link

I doubt. Let's keep it unchecked. This option can make a lot of sense for static resources, like hosts, but less so for dynamic resources.

The question is when should we fire such alert? I see two options -

  1. Let the user worry about it and make it a parameter to configure:
    [ ] Alert me if there's no data for X minutes.
  2. Give the user less parameters to worry about. Think of a good default value and use it. A hardcoded number obviously won't work, but something proportional to a check interval could do.

@Zacqary
Copy link
Contributor Author

Zacqary commented Apr 20, 2020

Looks like OUTSIDE_RANGE is fairly simple and adding the option to alert for no data is a bit more involved. I'll push two separate PRs for them

@Zacqary
Copy link
Contributor Author

Zacqary commented Apr 21, 2020

Going to branch off IS EMPTY into a second issue #64080

@Zacqary Zacqary changed the title [Metrics Alerts] Add OUTSIDE RANGE and IS EMPTY threshold conditions [Metrics Alerts] Add OUTSIDE RANGE threshold condition Apr 21, 2020
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants