Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPM] Unit-test fields.yml processing for index template mapping generation #60503

Closed
skh opened this issue Mar 18, 2020 · 2 comments
Closed

[EPM] Unit-test fields.yml processing for index template mapping generation #60503

skh opened this issue Mar 18, 2020 · 2 comments
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@skh
Copy link
Contributor

skh commented Mar 18, 2020

The changes in #60266 are not adequately unit-tested.

This task is to add unit tests for the processing of fields.yml data that happens in preparation for the generation of index template mappings. The implementation is in processFields() and the functions it calls, in ingest_manager/server/services/epm/fields/field.ts.
@skh skh added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label Mar 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@skh skh mentioned this issue Mar 18, 2020
Merged
@skh skh changed the title [EPM] Unit-test fields.yml processing for index template mapping generation [EPM] Unit-test fields.yml processing for index template mapping generation Mar 18, 2020
@skh skh removed their assignment Mar 19, 2020
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@ph ph added the technical debt Improvement of the software architecture and operational architecture label May 25, 2020
@jen-huang
Copy link
Contributor

jen-huang commented Apr 29, 2021 •
edited
Loading

We've added tests around processFields since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ph @skh @jen-huang @elasticmachine