Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling vis_type_vega causes an unhandled exception during runtime #59622

Closed
sorenlouv opened this issue Mar 8, 2020 · 2 comments · Fixed by #59737
Closed

Disabling vis_type_vega causes an unhandled exception during runtime #59622

sorenlouv opened this issue Mar 8, 2020 · 2 comments · Fixed by #59737
Assignees
@flash1293
Labels
bug Fixes for quality problems that affect the customer experience Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@sorenlouv
Copy link
Member

I'm seeing the following error in Kibana on master:
image

It's caused by this line:

kibana/src/legacy/core_plugins/vis_type_vega/public/plugin.ts

Line 71 in 5c43653

enableExternalUrls: visTypeVega.config.enableExternalUrls,

where visTypeVega is undefined because it has been disabled. I suggest solving this with a null check:

-  enableExternalUrls: visTypeVega.config.enableExternalUrls, 
+  enableExternalUrls: visTypeVega?.config.enableExternalUrls,

To repro add the following to config/kibana.yml:

vis_type_vega.enabled: false
@flash1293 flash1293 added bug Fixes for quality problems that affect the customer experience Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 self-assigned this Mar 9, 2020
@flash1293
Copy link
Contributor

Caused by #57011 , disabling the new platform plugin vis_type_vega doesn't disable the old one (it works the other way around).

@flash1293 flash1293 mentioned this issue Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flash1293 flash1293

Labels
bug Fixes for quality problems that affect the customer experience Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix vega config issue flash1293/kibana
3 participants
@sorenlouv @flash1293 @elasticmachine