Kibana 7.6: plugin installation fails

[fbaligand]

Kibana version:
7.6.0 and 7.6.1

Server OS version:
Windows 10 ans Linux RHEL 7

Original install method (e.g. download page, yum, from source, etc.):
download page

Describe the bug:
When I install a community plugin, I get the following error:
Plugin installation was unsuccessful due to error "Cannot delete files/directories outside the current working directory. Can be overridden with the force option."
I don't reproduce the issue on Kibana 7.5.x

Steps to reproduce:

1. install Kibana 7.6.1
2. launch command:
   ./kibana-plugin install https://github.com/fbaligand/kibana-enhanced-table/releases/download/v1.8.0/enhanced-table-1.8.0_7.6.1.zip
3. get the following output:

Attempting to transfer from https://github.com/fbaligand/kibana-enhanced-table/releases/download/v1.8.0/enhanced-table-1.8.0_7.6.1.zip
Transferring 718253 bytes....................
Transfer complete
Retrieving metadata from plugin archive
Extracting plugin archive
Extraction complete
Plugin installation was unsuccessful due to error "Cannot delete files/directories outside the current working directory. Can be overridden with the `force` option."

And plugin is not installed in "plugins" directory

Expected behavior:
Plugin installed correctly

Any additional context:
Discussion in slack: https://app.slack.com/client/TNLBGCXTQ/CRTSV34RK/thread/CRTSV34RK-1583478396.003800

[elasticmachine]

Pinging @elastic/kibana-operations (Team:Operations)

[spalger]

@fbaligand looks like the issue is that you've cd'd into the bin directory, so it's refusing to modify files outside of the bin directory as a precaution. If you do cd .. and then run bin/kibana-plugin ... it should work (worked for me locally)

[spalger]

What do you think we should do here? This is clearly a usability issue, maybe we should just have a better error message? Maybe validate that the cwd includes the kibana directory for cli tools like this one?

[fbaligand]

Hi,

Thanks for your answer @spalger !
I just tried your suggestion, and it worked great!

That said, in previous Kibana releases (7.5 and previous), we can install a kibana plugin directly from bin directory.
So it would be great if, in Kibana 7.6, we can also install a community plugin directly from bin directory.

[fbaligand]

By the way, it does not work also, if we are in another directory.
For example, if my current directory is "/home/fbaligand" and Kibana is in "/opt/kibana", I get the same error if I launch:
/opt/kibana/bin/kibana-plugin install file:///path/to/my-plugin.zip

And this worked perfectly in previous releases.

[spalger]

Yeah, okay, since this worked in previous versions I'll go ahead and track down the issue to make sure that it continues to work in the next version. Sorry for the break!

[fbaligand]

Thank you very much @spalger !