Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Jest Integration Tests.src/core/server/metrics/integration_tests - ServerMetricsCollector collect connection count #59236

Closed
kibanamachine opened this issue Mar 3, 2020 · 13 comments · Fixed by #65420
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Monitoring Stack Monitoring team

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 3, 2020

A test failed on a tracked branch

Error: connect ECONNRESET 127.0.0.1:45435
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1107:14)

First failure: Jenkins Build

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Mar 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@spalger spalger added the Team:Monitoring Stack Monitoring team label Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline chrisronline added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Apr 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@chrisronline
Copy link
Contributor

Adding platform team, as they technically own this

@pgayvallet
Copy link
Contributor

Is this occurring on a regular basis or is there only 2 failures in the last month?

@spalger
Copy link
Contributor

spalger commented Apr 8, 2020

It's not really regular, we've only had two failures in PRs, and only very recently:

image

@pgayvallet
Copy link
Contributor

This is probably caused by the only delay I couldn't replace with observable awaiting in the test.

await delay(requestWaitDelay);
metrics = await collector.collect();

Having a full stack trace would help to see where exactly it failed in the test and confirm that. but the two CI build failures are no longer accessible.

Will have to wait until next failure I guess?

@spalger
Copy link
Contributor

spalger commented Apr 9, 2020

Hmm, looking into it more closely I see the two PR failures were both in https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/39554/, which is seeing all ServerMetricsCollector tests fail because of the node.js version upgrade. In that case I think this might not have actually failed, even in PRs in the last 60 days so I'm going to close it.

@spalger spalger closed this as completed Apr 9, 2020
@kibanamachine kibanamachine reopened this May 5, 2020
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@spalger
Copy link
Contributor

spalger commented May 14, 2020

Backporting fix to 7.8 #66643

@pgayvallet
Copy link
Contributor

closing because of 7.8 backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Monitoring Stack Monitoring team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants