Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Enrich Privileges endpoint with NP Authentication data #59225

Closed
rylnd opened this issue Mar 3, 2020 · 3 comments
Closed

[SIEM] Enrich Privileges endpoint with NP Authentication data #59225

rylnd opened this issue Mar 3, 2020 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience critical Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0

Comments

@rylnd
Copy link
Contributor

rylnd commented Mar 3, 2020

NP does not currently provide the user's authentication status as a request header. Consequently, I've currently hardcoded the is_authenticated privilege to true. This needs to be replaced with equivalent logic before 7.7 is released.

My understanding is that one can disable the security plugin, disable authentication on elasticsearch, and interact with SIEM in an unauthenticated manner. With that hardcoded value above, they will be perceived as authenticated and things are going to enter undefined behavior.

Per this discussion, the NP work is still ongoing.

What's unclear to me is whether the above situation is going to play well with NP: I suppose it would just be const isAuthenticated = spaces?.isAuthenticated(request) ?? false? We don't seem to support the "optional auth" use case mentioned in the above issue, so that logic seems like it should work.

@rylnd rylnd added bug Fixes for quality problems that affect the customer experience critical v7.7.0 labels Mar 3, 2020
@rylnd rylnd self-assigned this Mar 3, 2020
@rylnd rylnd added the Team:SIEM label Mar 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@rylnd
Copy link
Contributor Author

rylnd commented Mar 4, 2020

Pinging @XavierM since I know you've touched this stuff recently.

@rylnd
Copy link
Contributor Author

rylnd commented Mar 26, 2020

Closed via #61334, backported to 7.7 and 7.x.

@rylnd rylnd closed this as completed Mar 26, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience critical Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0
Projects
None yet
Development

No branches or pull requests

3 participants