Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change plugin id for remote_clusters to remoteClusters #59183

Closed
joshdover opened this issue Mar 3, 2020 · 1 comment · Fixed by #59246
Closed

Change plugin id for remote_clusters to remoteClusters #59183

joshdover opened this issue Mar 3, 2020 · 1 comment · Fixed by #59246
Assignees
Labels
chore Feature:NP Migration Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@joshdover
Copy link
Contributor

joshdover commented Mar 3, 2020

The Platform now logs a warning when plugin IDs are not in camelCase format. remote_clusters needs to be renamed to remoteClusters in order to make this warning go away. This is important because this warning is confusing to users. We could just log the message in development, but it seems just as easy to just go ahead and do the rename now.

All this should entail is changing the id field in the kibana.json file and updating any plugins that depend on this plugin to use the new id when calling this plugin's APIs.

The config path does not need to change and should remain in snake_case.

@joshdover joshdover added chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:NP Migration labels Mar 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:NP Migration Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants