Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ui/styles to New Platform #58369

Closed
joshdover opened this issue Feb 24, 2020 · 6 comments · Fixed by #73154
Closed

Migrate ui/styles to New Platform #58369

joshdover opened this issue Feb 24, 2020 · 6 comments · Fixed by #73154
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

Before we remove ui/public we need to find a new home for the less and scss files in ui/styles and update all imports.

The easy option: src/core/public/styles?

cc @elastic/kibana-design
@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Feb 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@cchaos
Copy link
Contributor

cchaos commented Feb 24, 2020

@joshdover So long as they still get imported the same way as before, I don't think we have much opinion on where they "live". The folder you specified seems fine to me.

@lukeelmers lukeelmers mentioned this issue Feb 24, 2020
Closed
10 tasks
@flash1293
Copy link
Contributor

@joshdover Is this currently planned for 7.8? I had a problem referencing this from within a new platform stylesheet, not sure whether it's a blocker or possible to work around.

@joshdover
Copy link
Contributor Author

It is not currently prioritized, since the new webpack build for KP plugins automatically imports styling_constants. Do you need access to the other sheets (eg. bootstrap.less or font_awesome.less)?

@flash1293
Copy link
Contributor

It's about the mixins, so it should work just fine. I will check and report back with a specific error if something breaks.

@joshdover joshdover mentioned this issue Apr 20, 2020
Merged
8 tasks
@joshdover joshdover added the Feature:Legacy Removal Issues related to removing legacy Kibana label Apr 26, 2020
@joshdover joshdover mentioned this issue May 27, 2020
Closed
24 tasks
@epixa epixa mentioned this issue Jul 15, 2020
Closed
9 tasks
@joshdover joshdover mentioned this issue Jul 15, 2020
Merged
@pgayvallet pgayvallet mentioned this issue Jul 23, 2020
Closed
14 tasks
@spalger spalger mentioned this issue Aug 5, 2020
Merged
@spalger
Copy link
Contributor

spalger commented Aug 5, 2020

FYI, this be handled by #73154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove legacy optimizer spalger/kibana
5 participants
@cchaos @spalger @flash1293 @joshdover @elasticmachine