Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Use fork of expression service #58333

Closed
timroes opened this issue Feb 24, 2020 · 4 comments
Closed

[Lens] Use fork of expression service #58333

timroes opened this issue Feb 24, 2020 · 4 comments
Labels
blocked chore enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Feb 24, 2020

The expression service does now support forking. We should fork it inside Lens, and then register our lens specific functions on that fork (which can be used inside the editor and inside the embeddable), so we won't pollute Canvas autocompletion with the Lens internal expressions for now.

@timroes timroes added chore enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Feb 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes
Copy link
Contributor Author

timroes commented Mar 10, 2020

Blocked by #59744

@timroes timroes removed their assignment May 19, 2020
@flash1293
Copy link
Contributor

@ppisljar is this still up to date? Should Lens use forking to hide the internal functions? AFAIK this will be solved with tags instead, right?

@ppisljar
Copy link
Member

ppisljar commented Aug 6, 2020

yes lets close this one, we will work on either tag or flag to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked chore enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants