Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs / Metrics UI] [NP followup] Add functional tests back #58012

Closed
Kerry350 opened this issue Feb 19, 2020 · 1 comment
Closed

[Logs / Metrics UI] [NP followup] Add functional tests back #58012

Kerry350 opened this issue Feb 19, 2020 · 1 comment
Labels
chore Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature loe:small Small Level of Effort Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@Kerry350
Copy link
Contributor

Kerry350 commented Feb 19, 2020

As part of #54583 some functional tests were removed. This was due to inconsistent behaviour of timezones within the functional tests when using a custom space (the default space will use utc, whilst custom spaces uses browser time). This led to issues with rendering actual data (which relies on a point in time).

The tests for asserting that the app is accessible just had their behaviour changed (we can ascertain the app is accessible without rendering data). However, the tests for the context menu are still removed.

We should re-add these in some context, but outside the realm of a custom space. Or we could keep the custom space, but we'd need to add some test code to navigate to the settings page, and change the timezone to utc first.

@Kerry350 Kerry350 added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Feb 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature loe:small Small Level of Effort Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

4 participants