Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs / Metrics UI] [NP followup] Cleanup link-to routes #58005

Closed
Kerry350 opened this issue Feb 19, 2020 · 1 comment · Fixed by #61162
Closed

[Logs / Metrics UI] [NP followup] Cleanup link-to routes #58005

Kerry350 opened this issue Feb 19, 2020 · 1 comment · Fixed by #61162
Assignees
@Zacqary
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@Kerry350
Copy link
Contributor

Kerry350 commented Feb 19, 2020 •
edited by sgrodzicki
Loading

As part of #54583 the metrics and logs apps were changed to have their own unique App Ids, and therefore we now have /app/metrics and /app/logs rather than the old /app/infra. To facilitate this the routing was refactored so that metrics and logs have their own top level routers.

However, both routers render the full set of link-to routes, even though they will only respond to some of them.

We should refactor this so that the metrics app only renders the metrics based link-to routes (same for logs).

Extra context here.
@Kerry350 Kerry350 added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Feb 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Kerry350 Kerry350 changed the title [Logs / Metrics UI] [NP followup] Cleanup link-to routes [Logs / Metrics UI] [NP followup] Cleanup link-to routes Feb 19, 2020
@Kerry350 Kerry350 mentioned this issue Feb 19, 2020
Closed
11 tasks
@Zacqary Zacqary self-assigned this Mar 24, 2020
@Zacqary Zacqary mentioned this issue Mar 24, 2020
Merged
1 task
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zacqary Zacqary

Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs / Metrics UI] [NP followup] Cleanup link-to routes Zacqary/kibana
4 participants
@Kerry350 @sgrodzicki @Zacqary @elasticmachine