Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useRequest does not fetch when query has changed #57652

Closed
neptunian opened this issue Feb 14, 2020 · 2 comments · Fixed by #57723
Closed

useRequest does not fetch when query has changed #57652

neptunian opened this issue Feb 14, 2020 · 2 comments · Fixed by #57723
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@neptunian
Copy link
Contributor

https://github.com/elastic/kibana/blob/master/src/plugins/es_ui_shared/public/request/np_ready_request.ts#L147

Oftentimes path stays the same and the query changes to fetch unique results. A fetch should be performed, but is only performed if the path changes.

Expected Behavior:
useRequest should fetch the given path when the query has changed
@neptunian neptunian added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Feb 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@neptunian neptunian added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label Feb 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest (Feature:EPM)

@skh skh mentioned this issue Feb 14, 2020
Merged
This was referenced Feb 14, 2020
Merged
Merged
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix useRequest to support query change nchaulet/kibana
3 participants
@neptunian @jen-huang @elasticmachine