Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filters/brush_event]: Convert to TS / Jest #57395

Closed
2 tasks
lukeelmers opened this issue Feb 11, 2020 · 1 comment · Fixed by #58206
Closed
2 tasks

[filters/brush_event]: Convert to TS / Jest #57395

lukeelmers opened this issue Feb 11, 2020 · 1 comment · Fixed by #58206
Assignees
@VladLasitsa
Labels
Feature:NP Migration Feature:UIActions UI actions. These are client side only, not related to the server side actions..

Comments

@lukeelmers
Copy link
Member

src/legacy/core_plugins/data/public/actions/filters/brush_event.js

  • convert file (and tests) to TS
  • convert tests to Jest
    • tests seem to be using @kbn/expect which probably isn't necessary as we could use jest assertions
@lukeelmers lukeelmers added Team:AppArch Feature:NP Migration Feature:UIActions UI actions. These are client side only, not related to the server side actions.. labels Feb 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers changed the title [filters/brush_event]: Convert TS / Jest [filters/brush_event]: Convert to TS / Jest Feb 11, 2020
@VladLasitsa VladLasitsa mentioned this issue Feb 18, 2020
Closed
10 tasks
@alexwizp alexwizp assigned alexwizp and unassigned alexwizp Feb 19, 2020
@VladLasitsa VladLasitsa mentioned this issue Feb 21, 2020
Merged
10 tasks
@alexwizp alexwizp assigned VladLasitsa and unassigned alexwizp Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VladLasitsa VladLasitsa

Labels
Feature:NP Migration Feature:UIActions UI actions. These are client side only, not related to the server side actions..
Projects
None yet
Milestone
No milestone
4 participants
@lukeelmers @elasticmachine @VladLasitsa @alexwizp