Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @kbn/interpreter and refactor - 2 #57340

Closed
5 of 13 tasks
streamich opened this issue Feb 11, 2020 · 2 comments
Closed
5 of 13 tasks

Remove @kbn/interpreter and refactor - 2 #57340

streamich opened this issue Feb 11, 2020 · 2 comments
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@streamich
Copy link
Contributor

streamich commented Feb 11, 2020 •
edited
Loading

  • Move @kbn/interpreter PEG.js build step to expressions plugin.
    • Do not import parse function from @kbn/interpreter.
    • Build step can be added to src/dev/build/tasks.
  • Move @kbn/interpreter toExpression() function to expressions plugin.
  • ExpressionDataHandler ExecutionContract #57559
    • Move it to /common folder.
    • Rename it to ExecutionContract.
    • Make ExecutionContract use Execution internally.
  • Move renderering/React component to /common folder, too?
  • Other teams
    • Remove usage of @kbn/interpreter in Lens.
    • Remove usage of @kbn/interpreter in Canvas.
    • Move Registry implementation from @kbn/interpreter into Canvas.
  • Remove @kbn/interpreter package.

Parent issue: #46909
@streamich streamich added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Feb 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

This was referenced Feb 11, 2020
Closed
Merged
Merged
@lukeelmers lukeelmers mentioned this issue May 20, 2020
Merged
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Apr 20, 2021
@petrklapka petrklapka added 1 and removed 1 labels May 10, 2021
@ppisljar
Copy link
Member

closing this as we decided to keep the package and leave peg.js part there

@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@streamich @ppisljar @elasticmachine @petrklapka