Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expressions] Debug mode #56746

Closed
9 tasks done
streamich opened this issue Feb 4, 2020 · 2 comments · Fixed by #57841
Closed
9 tasks done

[Expressions] Debug mode #56746

streamich opened this issue Feb 4, 2020 · 2 comments · Fixed by #57841
Labels
enhancement New value added to drive a business result Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@streamich
Copy link
Contributor

streamich commented Feb 4, 2020

Add ability to execute expression in a "debug" mode, which would collect execution information about each function, which would be used in Expression Explorer (developed by Canvas) as well as in Canvas app when expression editor is open.

  • Add ability to execute expression in "debug" mode.
  • For each function should collect:
    • Input;
    • Output;
    • Arguments and info about sub-expressions, if any;
    • Reference to ExpressionFunctionDefinition;
    • Time it took to execute the function;
  • Debug information could be collected on:
    • An "execution chain"—a linked list of execution chain is created with debug information about every function as they execute. Note: this chain will contain information only until the first function that throws (because once one function throws expression executor stops execution).
    • Store debug information on the AST used to execute the function.
    • Create a new AST as expression executes.

Related:

Parent issue: #46909

@streamich streamich added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Feb 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

This was referenced Feb 4, 2020
@timductive timductive added enhancement New value added to drive a business result impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Feb 11, 2020
@streamich streamich added the 2sp label Feb 12, 2020
@streamich streamich mentioned this issue Feb 20, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants