Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Remove usage of rest_total_hits_as_int #56725

Closed
timroes opened this issue Feb 4, 2020 · 2 comments · Fixed by #84340
Closed

[Lens] Remove usage of rest_total_hits_as_int #56725

timroes opened this issue Feb 4, 2020 · 2 comments · Fixed by #84340
Assignees
@flash1293
Labels
blocker Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture v8.0.0

Comments

@timroes
Copy link
Contributor

timroes commented Feb 4, 2020

The parameter rest_total_hits_as_int is deprecated and will be removed in 8.0 in Elasticsearch. We need to remove it from all places it's used in Lens, and instead work with the new hits format (and estimated count values).

Related to #26356
@timroes timroes added blocker Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens labels Feb 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

The main reason I switched to this was because our type definitions were set for the 6.x client, not 7.x, and this setting was for backwards compatibility.

@flash1293 flash1293 added the technical debt Improvement of the software architecture and operational architecture label Aug 6, 2020
@flash1293 flash1293 mentioned this issue Aug 14, 2020
Closed
43 tasks
@flash1293 flash1293 self-assigned this Nov 25, 2020
@flash1293 flash1293 mentioned this issue Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flash1293 flash1293

Labels
blocker Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Migrate legacy es client and remove total hits as int flash1293/kibana
4 participants
@wylieconlon @timroes @flash1293 @elasticmachine