Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui/utils/query_string]: Remove unused methods & migrate apps to querystring lib #56704

Closed
6 tasks
lukeelmers opened this issue Feb 3, 2020 · 1 comment · Fixed by #56957
Closed
6 tasks
Assignees

Comments

@lukeelmers
Copy link
Member

Part of #51560

Currently src/legacy/ui/public/utils/query_string is used several places, but according to this comment can probably be replaced in favor of the existing querystring dependency in Kibana.

  • QueryString.encode -> replace uses with querystring.stringify (double-check outputs are identical)
  • QueryString.decode -> replace uses with querystring.parse (double-check outputs are identical)
  • QueryString.findInUrl -> can be removed as it appears to be unused
  • QueryString.param -> a simple util that's only used in canvas. we should just copy it over
  • QueryString.replaceParamInUrl -> only used in state management and will get left behind
  • Update 7.7 dev docs issue with documentation on the above changes
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants