Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin generator translations and external deps #56652

Closed
2 of 3 tasks
lizozom opened this issue Feb 3, 2020 · 5 comments · Fixed by #57766
Closed
2 of 3 tasks

Plugin generator translations and external deps #56652

lizozom opened this issue Feb 3, 2020 · 5 comments · Fixed by #57766

Comments

@lizozom
Copy link
Contributor

lizozom commented Feb 3, 2020

Follow up for #55281

The following features should be re-introduced into the new plugin generator

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@tylersmalley
Copy link
Contributor

I would also like to add that with #55281 we removed the ability for 3rd party plugins to be able to build themselves. This previously was part of the package.json build script which used the plugin-helpers.

@sszilvasi
Copy link

Is it currently possible to add external dependencies to 3rd party NP plugins?

@spalger
Copy link
Contributor

spalger commented Jun 2, 2020

Is it currently possible to add external dependencies to 3rd party NP plugins?

Yes, you can install as many packages from npm as you like. They should be included in the 3rd party plugin's downloaded archive because Kibana doesn't install them when your plugin is installed (to support offline install)

@sszilvasi
Copy link

@lizozom @spalger Thanks, the original answer solved my problem.

Just run the following commands in the plugin folder:

npm init
npm install <somepackage>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants