Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Loading a plugin from plugins directory flickers #56362

Closed
lizozom opened this issue Jan 30, 2020 · 4 comments
Closed

[BUG] Loading a plugin from plugins directory flickers #56362

lizozom opened this issue Jan 30, 2020 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0 v8.0.0

Comments

@lizozom
Copy link
Contributor

lizozom commented Jan 30, 2020

To reproduce:

  1. Generate a new plugin using the plugin generator
  2. Place a breakpoint in plugins/moo_123/public/application.tsx, before the render.
  3. Start kibana and navigate to the plugin.

Result:

This screen shows:

image

Without the breakpoint, this screen flickers and disappears once the plugin renders.

@lizozom lizozom added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform v8.0.0 v7.7.0 labels Jan 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor

This is very likely to be related to #54656. Sounds like the router is mounting the app slightly before the state observer emit? Not sure how or why though.

Also I'm not sure to see how there could be a difference between internal and 3rd parties plugins behavior.

@lizozom
Copy link
Contributor Author

lizozom commented Jan 30, 2020

@pgayvallet I haven't tested whether this happens with a new non 3rd party plugin!

@pgayvallet
Copy link
Contributor

closing in favor of #56409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

3 participants