Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph] Migrate client side plugin #56290

Closed
flash1293 opened this issue Jan 29, 2020 · 2 comments
Closed

[Graph] Migrate client side plugin #56290

flash1293 opened this issue Jan 29, 2020 · 2 comments
Labels
Feature:Graph Graph application feature Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

The client side Graph app should get migrated with angular used locally within the plugin.

Currently it still uses several legacy imports that should either get cleaned up or moved to the NP together with the plugin:

  • export { SavedObject, SavedObjectKibanaServices } from 'ui/saved_objects/types'; - wait for Move saved object modal into new platform #55423
  • export { configureAppAngularModule } from 'ui/legacy_compat'; - pick out relevant pieces and migrate just them - try to avoid moving the whole legacy_compat module as it depends on a lot of other things
  • export { createTopNavDirective, createTopNavHelper } from 'ui/kbn_top_nav/kbn_top_nav'; - Move over into kibana_legacy
  • export { confirmModalFactory } from 'ui/modals/confirm_modal'; - wait for Remove usages of confirmModal #55428
  • export { addAppRedirectMessageToUrl } from 'ui/notify'; - Move into kibana_legacy and make it part of the local application service
  • export { SaveResult } from 'ui/saved_objects/show_saved_object_save_modal'; - wait for Move saved object modal into new platform #55423
  • export { createSavedObjectClass } from 'ui/saved_objects/saved_object'; - move over in separate PR
  • export { showSaveModal } from 'ui/saved_objects/show_saved_object_save_modal'; - wait for Move saved object modal into new platform #55423

Cleaning up the dependencies can also happen in separate PRs. Migrations and styling can be left behind for now.

@flash1293 flash1293 added Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels Jan 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor Author

Closing as duplicate - didn’t realize I already started an issue for this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Graph Graph application feature Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants