Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interface for sharing urls #5523

Closed
BigFunger opened this issue Nov 30, 2015 · 7 comments
Closed

Improve interface for sharing urls #5523

BigFunger opened this issue Nov 30, 2015 · 7 comments

Comments

@BigFunger
Copy link
Contributor

From @tsullivan in #5497

It might be preferable to have these in <textarea readonly="readonly"></textarea> and have it so when you click inside, it auto-selects the block for easy copying. Kind of like is shown in this trick: https://css-tricks.com/snippets/javascript/auto-select-textarea-text/

I didn't want to implement this in #5497 because it was slightly out of scope for that issue. There was also in the past, functionality that allowed the user to copy the url into the clipboard. Since that functionality was removed, I agree with Tim that the user experience is less than ideal. Figured I would offer this up for some discussion.

@jbudz
Copy link
Member

jbudz commented Nov 30, 2015

Might be worth trying https://github.com/zenorocha/clipboard.js/, it will select text on browsers that aren't supported. No flash/native = maybe less issues than Zeroclipboard

@tsullivan
Copy link
Member

https://github.com/zenorocha/clipboard.js/

you can show a tooltip saying "Copied!" when success event is called and "Press Ctrl+C to copy" when error event is called because the text is already selected.

Since we can change the message if text is only selected (vs. being copied), this sounds like a good recommendation to me.

@tsullivan
Copy link
Member

Maybe this behavior should also cover the Request and Response tabs of the spy panel.

@zenorocha
Copy link

+1 ;)

@BigFunger BigFunger self-assigned this Dec 7, 2015
@zenorocha
Copy link

I see this issue is closed... Is clipboard.js being used on Kibana now?

@jbudz
Copy link
Member

jbudz commented Oct 13, 2016

@zenorocha
Copy link

Nice! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants