-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve interface for sharing urls #5523
Comments
Might be worth trying https://github.com/zenorocha/clipboard.js/, it will select text on browsers that aren't supported. No flash/native = maybe less issues than Zeroclipboard |
https://github.com/zenorocha/clipboard.js/
Since we can change the message if text is only selected (vs. being copied), this sounds like a good recommendation to me. |
Maybe this behavior should also cover the Request and Response tabs of the spy panel. |
+1 ;) |
I see this issue is closed... Is clipboard.js being used on Kibana now? |
It was briefly but isn't anymore, https://github.com/elastic/kibana/blob/master/src/ui/public/share/directives/share.js#L147 |
Nice! :) |
From @tsullivan in #5497
I didn't want to implement this in #5497 because it was slightly out of scope for that issue. There was also in the past, functionality that allowed the user to copy the url into the clipboard. Since that functionality was removed, I agree with Tim that the user experience is less than ideal. Figured I would offer this up for some discussion.
The text was updated successfully, but these errors were encountered: