-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Norwegian locale for number formatters #54351
Comments
Pinging @elastic/kibana-platform (Team:Platform) |
Will be solved via #53972 |
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Yes, my change will help, but we should also update our fork. |
Closure SummaryRecap
Cause
Takeaways
|
I think this has been closed prematurely- the PR I have worked on will definitely not be in 7.7 |
My apologies. Incorrect repository. |
Is it an option to update the NumeralJs fork in Kibana with additional localizations, so the issue is mitigated? Or is that a big task? |
I don't expect that it's a large task, but I am not qualified to provide logic for Norwegian. Feel free to submit a pull request: https://github.com/elastic/numeral-js/tree/kibana-fork/languages |
Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment. |
Describe the feature:
I would like to add Norwegian locale support in to Kinana number formatters.
At the moment, Kibana fork of numeral.js does not have no locale: (https://github.com/elastic/numeral-js/tree/kibana-fork/languages)
However, official master has the implementation available: https://github.com/adamwdraper/Numeral-js/tree/master/locales
Describe a specific use case for the feature:
More users will be happy with correct selection for their language.
The text was updated successfully, but these errors were encountered: