Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Norwegian locale for number formatters #54351

Closed
radoondas opened this issue Jan 9, 2020 · 10 comments
Closed

Add Norwegian locale for number formatters #54351

radoondas opened this issue Jan 9, 2020 · 10 comments
Labels
enhancement New value added to drive a business result Feature:FieldFormatters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@radoondas
Copy link
Member

Describe the feature:
I would like to add Norwegian locale support in to Kinana number formatters.
At the moment, Kibana fork of numeral.js does not have no locale: (https://github.com/elastic/numeral-js/tree/kibana-fork/languages)

However, official master has the implementation available: https://github.com/adamwdraper/Numeral-js/tree/master/locales

Describe a specific use case for the feature:
More users will be happy with correct selection for their language.

@tsullivan tsullivan added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed labels Jan 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@timroes
Copy link
Contributor

timroes commented Jan 10, 2020

Will be solved via #53972

@timroes timroes added Feature:FieldFormatters Team:AppArch and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jan 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@wylieconlon
Copy link
Contributor

Yes, my change will help, but we should also update our fork.

@radoondas
Copy link
Member Author

Closure Summary

Recap

  • Missing Norwegian locale in Kibana formatting options
  • We are using old implementation of the library which provides locale
  • Will be fixed in new version of Kibana (7.7?) where we will implement different approach for the formatting. See linked issues.

Cause

  • old JS library for formatting

Takeaways

  • Shouldl be fixed in v7.7?

@wylieconlon wylieconlon reopened this Feb 3, 2020
@wylieconlon
Copy link
Contributor

I think this has been closed prematurely- the PR I have worked on will definitely not be in 7.7

@radoondas
Copy link
Member Author

My apologies. Incorrect repository.

@pettertho
Copy link

Is it an option to update the NumeralJs fork in Kibana with additional localizations, so the issue is mitigated? Or is that a big task?

@wylieconlon
Copy link
Contributor

I don't expect that it's a large task, but I am not qualified to provide logic for Norwegian. Feel free to submit a pull request: https://github.com/elastic/numeral-js/tree/kibana-fork/languages

@lukeelmers lukeelmers added enhancement New value added to drive a business result and removed triage_needed labels Jul 2, 2020
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 14, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jun 21, 2021
@petrklapka
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@petrklapka petrklapka closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2022
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:FieldFormatters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

8 participants