Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Infinite requests for index pattern #54151

Closed
justinkambic opened this issue Jan 7, 2020 · 1 comment · Fixed by #54160
Closed

[Uptime] Infinite requests for index pattern #54151

justinkambic opened this issue Jan 7, 2020 · 1 comment · Fixed by #54160
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.6.0

Comments

@justinkambic
Copy link
Contributor

Kibana version:
master

Elasticsearch version:
yarn es snapshot

Server OS version:
macOS

Browser version:
Chrome 79.*

Browser OS version:
macOS

Original install method (e.g. download page, yum, from source, etc.):
from source

Describe the bug:
There's an issue where the Uptime Overview page makes an infinite series of requests to the index pattern API endpoint.

Steps to reproduce:

  1. Open browser console
  2. Navigate to Uptime
  3. Observe the issue

Expected behavior:
There would be a single request for the index pattern.

Screenshots (if relevant):
image

Errors in browser console (if relevant):
N/A

Provide logs and/or server output (if relevant):
N/A

Any additional context:
This is due to the inclusion of a setter from useState as a dependency of the useEffect used by our useIndexPattern hook. As a temporary fix, we should ignore the eslint rule for this line, and remove that function as a dependency of the hook. Longer term, we should migrate away from individual components being responsible to fetch this.

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.6.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants