Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Add percy snapshot testing for storybook #54149

Closed
poffdeluxe opened this issue Jan 7, 2020 · 1 comment · Fixed by #139252
Closed

[Canvas] Add percy snapshot testing for storybook #54149

poffdeluxe opened this issue Jan 7, 2020 · 1 comment · Fixed by #139252
Labels
Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture

Comments

@poffdeluxe
Copy link
Contributor

poffdeluxe commented Jan 7, 2020 •
edited
Loading

Percy has their own Storybook integration to allow easy snapshotting of Storybooks. https://docs.percy.io/docs/storybook

In order to get this working with Canvas, we'd have to generate the static storybook site (which our storybook script is already capable of) and then pass the built statics to the percy-storybook tool via the --build_dir=my-static-storybook command-line option.

For future integration with CI/Jenkins, we could add on to the jenkins_xpack_visual_regression.sh script that kicks of the Percy snapshotting on x-pack plugins.
@poffdeluxe poffdeluxe added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jan 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@timductive timductive added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. technical debt Improvement of the software architecture and operational architecture labels Feb 11, 2020
@tylersmalley tylersmalley mentioned this issue Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes Percy based visual regression tests tylersmalley/kibana
4 participants
@poffdeluxe @timroes @timductive @elasticmachine