-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSVB doesn't scroll correctly with color picker open #52084
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
EUI now has its own color picker and this implementation should just be swapped for that. https://elastic.github.io/eui/#/forms/color-selection |
Hi @cchaos I've taken over this task but I cannot find the transparency setting in the new EUI color picker that would be equivalent of the one in the picture: Are there plans to implement it in the future? Is the assumption to implement this setting outside of EUI? |
Ahh, yes, the EUI component does not yet have an opacity slider. Though it should be pretty easy to add and should be added on the EUI side. I'll create a ticket. |
|
@thompsongl what functionality is missing from the existing color picker? |
Assuming you stay with the swatch-style button to open the color picker popover, there is no input to manually enter color strings. Not sure how important it is to this use case, but if it remains a blocker, let me know and we can get it prioritized. |
Since TSVB is rather much used, I think we should not exchange the color picker without giving the users the ability to enter hex codes as they could before. The problem is that without that there is no way to get to a "specific color", meaning the users wouldn't e.g. be able to use their corporate colors (or any other color they know about), because they can just "try to get it". |
Added the last remaining feature to unblock this. The next EUI release (v23.0.0, I think) will allow for color value text entry with the swatch-style button. |
If you go to TSVB and create enough new series, so you hit the bottom of your screen and trying to open the color picker in the bottom most series (or any other way it will go outside the screen), you can actually not scroll the page further down to see all of the color picker and properly use it. If you're running on a system showing scrollbars in the browser, you'll also see that there seem to be two layers of scrolling, but the wrong layer will get the scroll:
Expected behavior: we should be able to scroll down to see all of the color picker to actually use it.
Blocking issue: elastic/eui#2629
The text was updated successfully, but these errors were encountered: