Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fails behind http_proxy #5196

Closed
Filirom1 opened this issue Oct 26, 2015 · 4 comments
Closed

Tests fails behind http_proxy #5196

Filirom1 opened this issue Oct 26, 2015 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience dev stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@Filirom1
Copy link
Contributor

Hi,

Tests are failing when we are behind an http_proxy because wreck is used.
https://github.com/elastic/kibana/blob/master/tasks/build/downloadNodeBuilds.js#L24

Wreck do not handle http_proxy.
hapijs/wreck#64

Request works better with http_proxy.
https://github.com/request/request#controlling-proxy-behaviour-using-environment-variables

@rashidkpc
Copy link
Contributor

Not likely to fix this soon, if someone wants to submit a pull to convert wreck to request, we'd consider it. Probably better off implementing http_proxy support in wreck though

@rashidkpc rashidkpc added bug Fixes for quality problems that affect the customer experience dev labels Oct 26, 2015
@tuxtitlan
Copy link

Hi @rashidkpc, any news on supporting proxies on Kibana 5.0?

@rashidkpc
Copy link
Contributor

We have no immediate plans to fix this, though we'd consider a pull to replace wreck.

@barryib
Copy link

barryib commented Aug 9, 2016

I just submitted the PR #7967 to replace Wreck with Request module and add proxy support.

@timroes timroes added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Aug 17, 2018
@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience dev stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

6 participants