Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is able to start creating a policy with no repository created #51395

Closed
cuff-links opened this issue Nov 21, 2019 · 5 comments
Closed

User is able to start creating a policy with no repository created #51395

cuff-links opened this issue Nov 21, 2019 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cuff-links
Copy link
Contributor

Environment

Kibana: 7.5.0 BC7
Elasticsearch 7.5.0 BC 7
Browsers: Firefox and Chrome (Both latest)

Preconditions:
Ensure you have no snapshots, policies or repositories created.

Steps to reproduce:
1.) Navigate to Snapshot and Restore
2.) Navigate to the policies tab

Expected Result:
A message telling you that there are no repositories created and and a button for you to create one.

Actual Result:
Create a New policy button which works and lets you go try to create one.

@cuff-links cuff-links added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI labels Nov 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cuff-links cuff-links added the bug Fixes for quality problems that affect the customer experience label Nov 21, 2019
@alisonelizabeth alisonelizabeth added enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience labels Nov 22, 2019
@alisonelizabeth
Copy link
Contributor

@cuff-links thanks for opening this!

I'm going to change this to an enhancement. We do alert the user that there are no repositories when they go into the create flow.

Screen Shot 2019-11-22 at 9 04 49 AM

If we want to alert them one step sooner on the policies page (as you suggest), we would need to make an additional request on the policies page to fetch the repositories to see if any exist. We also need to consider the best UI/UX. I think it's straightforward if the user has no policies set up. But, you could also end up in this situation if a repo(s) was deleted with existing policies (relates to #46791).

@cuff-links
Copy link
Contributor Author

cuff-links commented Nov 24, 2019

@alisonelizabeth Can a policy be created independent of a repository? If not, we shouldn't let them start creating something that depends on a repository without one being configured. Also, in the creation flow, a user can just skip past that warning as the next button is still enabled as pointed out in #51397.

@cuff-links
Copy link
Contributor Author

If a repository is not optional, i think it would be good UX to point the user to the Repo page just as we do in the snapshots tab. That would be consistent.

@alisonelizabeth
Copy link
Contributor

I'm going to close this for now. While it may be more optimal to show a prompt before clicking into the policy wizard, I think the current UI still makes it clear that a repository must be registered first.

Also, in the creation flow, a user can just skip past that warning as the next button is still enabled as pointed out in #51397.

I agree this is a valid bug. Let's address it via #51397.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants