Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom interval per alert type #51203

Closed
mikecote opened this issue Nov 20, 2019 · 6 comments · Fixed by #113650
Closed

Custom interval per alert type #51203

mikecote opened this issue Nov 20, 2019 · 6 comments · Fixed by #113650
Assignees
Labels
enhancement New value added to drive a business result estimate:medium Medium Estimated Level of Effort Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting/RulesManagement Issues related to the Rules Management UX Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Nov 20, 2019

Would be nice to be able to specify:

  • default interval per alert type
  • minimum interval. This could be by alert type or in general. It's been mentioned that some may not want users to be able to make alerts run too frequently and bring their system down. Original issue Ability to set a minimum interval for alerts #51194
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@mikecote
Copy link
Contributor Author

mikecote commented Feb 3, 2021

Use case from @darnautov to provide a default or recommended interval (#89880 (comment))

It's not that critical for us to set the interval programmatically, but it'll definitely help with a better default value. For instance, if the anomaly detection job configuration has a narrow bucket span, it's worth decreasing the check interval so the user is notified about the anomalous data on time.

@pmuellr
Copy link
Member

pmuellr commented Mar 3, 2021

This makes sense to me. I guess the alert type would define some "default" values for things like interval and throttle (null might be appropriate for some, on-status-change for others). I think those are the two generic alert parameters that would make sense to allow an alert type to provide defaults for.

This fits into my "default all the things" thoughts as well, where we should be allowing nullable values for config/params which could be filled in by alert/action types, out of the box. So we can also make use of these "defaults" for anyone using the HTTP APIs directly. But it has a lot more value just in the UI for now.

@mikecote
Copy link
Contributor Author

mikecote commented Mar 3, 2021

This could work well with #51194 if it doesn't make sense to have alerts run so frequently.

@pmuellr
Copy link
Member

pmuellr commented Mar 3, 2021

Ya, adding some constraints here like "minimum interval" sound good as well. But will then require the params validation to get tweaked - which could actually get complicated if it has to go in the config-schema validation.

@ymao1 ymao1 changed the title Default interval per alert type Custom interval per alert type Mar 4, 2021
@pmuellr
Copy link
Member

pmuellr commented Mar 4, 2021

From issue #89898 (comment)

Another type of rule-type validation of general rule params comes from the anomaly detection rule type - for that one, ML jobs are already configured with an interval of some sort, which should influence the rule interval itself. Specifically, there's no sense making it smaller than the interval in the ML job.

In this case, we'd want to somehow allow the rule to override the interval, based on some other rule-specific application data. In the particular case of anomaly detection rules, each rule can deal with multiple ML jobs, so presumably we'd collect the minimum interval of those jobs, and use it to set the minimum interval in the rule itself.

Not sure if this would just be a UI thing, or something lower-level, in the rule processing itself. But in any case, it needs to be "live", based on existing ES resources, and not just "static".

@gmmorris gmmorris added Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting/RulesManagement Issues related to the Rules Management UX labels Jul 1, 2021
@gmmorris gmmorris added the loe:large Large Level of Effort label Jul 14, 2021
@gmmorris gmmorris added enhancement New value added to drive a business result estimate:medium Medium Estimated Level of Effort labels Aug 13, 2021
@gmmorris gmmorris removed the loe:large Large Level of Effort label Sep 2, 2021
@chrisronline chrisronline self-assigned this Sep 30, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result estimate:medium Medium Estimated Level of Effort Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting/RulesManagement Issues related to the Rules Management UX Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants