Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana app migration: Move static code dependencies into kibana_legacy plugin #50670

Closed
17 of 24 tasks
flash1293 opened this issue Nov 14, 2019 · 3 comments
Closed
17 of 24 tasks
Assignees
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented Nov 14, 2019

The various Kibana app apps (discover, visualize, dashboard, graph) all rely partially on the same static code to run angular locally within the plugin. When we are starting the actual cutover, those also have to move to the Kibana platform.

There will be a legacy service handling a few things in the migration phase and handling redirect of URLs after that anyway, so this service can also provide these static code portions apps moved to the Kibana platform.

This should happen as late as feasible in the process to only copy the legacy pieces actually needed in the new platform.

Collection of dependencies:

  • Legacy state management src/legacy/ui/public/state_management ui/persisted_state, ui/events
  • "Private" ui/private/private
  • Promises ui/promises/promises
  • kbn top nav directive definition src/legacy/ui/public/kbn_top_nav
  • syncOnMount function that is used in Dashboard and Visualize
  • kbn url src/legacy/ui/public/url
  • migrateLegacyQuery ui/utils/migrate_legacy_query
  • ui/compat and ui/legacy_compat
  • registerTimefilterWithGlobalStateFactory ui/timefilter/setup_router
  • ui/directives/watch_multi/watch_multi
  • ui/accessibility/kbn_accessible_click
  • ui/directives/listen/listen
  • ui/utils/simple_emitter
  • ui/utils/collection
  • ui/notify/app_redirect/app_redirect.js
  • ui/vis/lib/timezone
  • ui/utils/subscribe_with_scope

The following imports are only used by discover and can be inlined into the discover plugin directly

In all cases it should be checked whether it's possible to migrate away from the helper with little effort - if that's the case, it is preferable over copying over the helper.

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels Nov 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member

kertal commented Jan 27, 2020

I'll start with the Discover Deps

@flash1293
Copy link
Contributor Author

Those are either done are tracked in #60097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants