Loading maps, discover, visualize and dashboards logs backend.js:6 TypeError: (0 , _url.modifyUrl) is not a function in console

[bhavyarm]

Kibana version: 7.5.0 BC4

Elasticsearch version: 7.5.0 BC4

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If you navigate to maps, discover, visualize and dashboards Kibana logs
TypeError: (0 , _url.modifyUrl) is not a function in the console.

Steps to reproduce:

1. Open Kibana and browser console
2. Open maps - open a single map Kibana logs ''TypeError: (0 , _url.modifyUrl) is not a function"
3. Open dashboard - Kibana logs TypeError: (0 , _url.modifyUrl) is not a function and so on

Screenshots (if relevant):

Errors in browser console (if relevant):

backend.js:6 TypeError: (0 , _url.modifyUrl) is not a function
    at check (commons.bundle.js:3)
    at Scope.$broadcast (vendors.bundle.dll.js:435)
    at prepareRoute (vendors.bundle.dll.js:257)
    at Scope.$broadcast (vendors.bundle.dll.js:435)
    at vendors.bundle.dll.js:435
    at Scope.$digest (vendors.bundle.dll.js:435)
    at Scope.$apply (vendors.bundle.dll.js:435)
    at bootstrapApply (vendors.bundle.dll.js:435)
    at Object.invoke (vendors.bundle.dll.js:435)
    at doBootstrap (vendors.bundle.dll.js:435)
r @ backend.js:6
(anonymous) @ vendors.bundle.dll.js:435
(anonymous) @ vendors.bundle.dll.js:435
$broadcast @ vendors.bundle.dll.js:435
prepareRoute @ vendors.bundle.dll.js:257
$broadcast @ vendors.bundle.dll.js:435
(anonymous) @ vendors.bundle.dll.js:435
$digest @ vendors.bundle.dll.js:435
$apply @ vendors.bundle.dll.js:435
bootstrapApply @ vendors.bundle.dll.js:435
invoke @ vendors.bundle.dll.js:435
doBootstrap @ vendors.bundle.dll.js:435
bootstrap @ vendors.bundle.dll.js:435
chrome.bootstrap @ commons.bundle.js:3
start @ commons.bundle.js:3
_callee2$ @ commons.bundle.js:3
tryCatch @ vendors.bundle.dll.js:489
invoke @ vendors.bundle.dll.js:489
forEach.prototype.<computed> @ vendors.bundle.dll.js:489
asyncGeneratorStep @ commons.bundle.js:3
_next @ commons.bundle.js:3
Promise.then (async)
asyncGeneratorStep @ commons.bundle.js:3
_next @ commons.bundle.js:3
Promise.then (async)
asyncGeneratorStep @ commons.bundle.js:3
_next @ commons.bundle.js:3
Promise.then (async)
asyncGeneratorStep @ commons.bundle.js:3
_next @ commons.bundle.js:3
Promise.then (async)
asyncGeneratorStep @ commons.bundle.js:3
_next @ commons.bundle.js:3
Promise.then (async)
asyncGeneratorStep @ commons.bundle.js:3
_next @ commons.bundle.js:3
Promise.then (async)
asyncGeneratorStep @ commons.bundle.js:3
_next @ commons.bundle.js:3
Promise.then (async)
asyncGeneratorStep @ commons.bundle.js:3
_next @ commons.bundle.js:3
Promise.then (async)
asyncGeneratorStep @ commons.bundle.js:3
_next @ commons.bundle.js:3
Promise.then (async)
asyncGeneratorStep @ commons.bundle.js:3
_next @ commons.bundle.js:3
Promise.then (async)
asyncGeneratorStep @ commons.bundle.js:3
_next @ commons.bundle.js:3
(anonymous) @ commons.bundle.js:3
(anonymous) @ commons.bundle.js:3
start @ commons.bundle.js:3
(anonymous) @ kibana.bundle.js:3
Promise.then (async)
(anonymous) @ kibana.bundle.js:3
Promise.then (async)
__kbnBundles__.kibana @ kibana.bundle.js:3
__webpack_require__ @ kibana.bundle.js:3
checkDeferredModules @ kibana.bundle.js:3
__kbnBundles__.kibana @ kibana.bundle.js:3
(anonymous) @ kibana.bundle.js:3

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[flash1293]

@bhavyarm Could you share your saved objects? I tried with the sample data on a development server as well as the BC directly and I don't get the message.

[bhavyarm]

@flash1293 lets talk tomorrow. I can reproduce this easily. Thanks!

[bhavyarm]

So can't reproduce this on 7.5.0 BC4. Will try again on BC5 and then close the bug if I can't. Thanks @flash1293

[nreese]

I can reproduce this problem on master. It mostly happens when adding filters while the mentioned apps.

[nreese]

I have tracked down this error and figured out the cause.

Follow these steps to reproduce:

1. install web logs sample data
2. open Maps saved object that ships with sample data.
3. click in the United States polygon and create a filter from the United States polygon.
4. This will cause the URL to overflow 1000 character limit but no warning is displayed. More on that later.
5. The error will always occur on any URL change after this because the URL is stored in session state at error/url-overflow/url and never gets cleared. (Need to figure that out next). @bhavyarm That is why you are not seeing issue User cannot navigate back to a map with saved multipolygon filter from elsewhere in Kibana for almost 4-5 minutes in chrome #50652 when starting an incognito tab

There is a bug in angular_config method $setupUrlOverflowHandling at https://github.com/elastic/kibana/blob/master/src/legacy/ui/public/legacy_compat/angular_config.tsx#L356. modifyUrl does not exist. PR #38237 removed src/core/public/utils/modify_url.ts which was duplicated in src/core/utils/url.ts but failed to update the path referenced by ui/url/index.js. Since the path referenced by ui/url/index.js still hit an index.js file, no build exception occurred.

[nreese]

@flash1293 Opened #50747 to resolve this issue.

[flash1293]

@nreese Thanks for looking into this, it was on my list for today, but I probably would not have figured it out so fast. Can I also assign this issue to you?