Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Saved Objects interaction is performed with an unnecessary custom client #49977

Closed
justinkambic opened this issue Nov 1, 2019 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture

Comments

@justinkambic
Copy link
Contributor

Kibana version:
master

Elasticsearch version:
master

Server OS version:
macOS

Browser version:
Chrome 77

Browser OS version:
macOS

Original install method (e.g. download page, yum, from source, etc.):
from source

Describe the bug:
When we implemented a Saved Objects client in the Uptime app we created our own custom client, rather than utilizing the provided getter method available on http requests. This can lead to things like ignoring Spaces when making requests, among other pitfalls.

Steps to reproduce:
This is more of an implementation mistake than a bug that breaks functionality. There should be no noticeable difference in the user's interaction with Kibana after the issue is fixed.

Expected behavior:
The Uptime app's server code should simply use the getter function supplied as part of the request object.

Screenshots (if relevant):
N/A

Errors in browser console (if relevant):
N/A

Provide logs and/or server output (if relevant):
N/A

Any additional context:
N/A

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience technical debt Improvement of the software architecture and operational architecture Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 1, 2019
@justinkambic justinkambic self-assigned this Nov 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic
Copy link
Contributor Author

This was resolved by #51403.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants