Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Elasticsearch: remove "data" and "admin" clients and expose single client #49870

Closed
rudolf opened this issue Oct 31, 2019 · 3 comments · Fixed by #67596
Closed

Core Elasticsearch: remove "data" and "admin" clients and expose single client #49870

rudolf opened this issue Oct 31, 2019 · 3 comments · Fixed by #67596
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0

Comments

@rudolf
Copy link
Contributor

rudolf commented Oct 31, 2019

For "tribe mode" support, we used to expose two elasticsearch clients a "data" and "admin" client. Since Kibana no longer supports "tribe mode" Core should expose a single Elasticsearch client.

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform v8.0.0 labels Oct 31, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover
Copy link
Contributor

With the proposal to add the new Elasticsearch.js client alongside the existing clients in #35508, I think this work may be unnecessary churn. There's no increased maintenance burden in continuing to support both adminClient and dataClient. It seems we can just remove both of these once we decide to drop support for the legacy client, no?

@rudolf
Copy link
Contributor Author

rudolf commented Nov 1, 2019

Yeah this is probably low priority and can be done as part of #35508. I think the cost is more on the API consumer side, it adds confusion and two ways to do the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants