Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary x-pack/legacy/plugins/siem eslint overrides #49571

Closed
spalger opened this issue Oct 28, 2019 · 2 comments
Closed

Remove temporary x-pack/legacy/plugins/siem eslint overrides #49571

spalger opened this issue Oct 28, 2019 · 2 comments
Assignees

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019

In order to move forward with #49244 we needed to disable some rules in x-pack/legacy/plugins/siem. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['x-pack/legacy/plugins/siem/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/exhaustive-deps': 'off',
    'react-hooks/rules-of-hooks': 'off',
  },
},
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski
Copy link
Contributor

Fixed, Thank you @spalger for taking care of that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants