Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary packages/kbn-ui-framework eslint overrides #49541

Closed
spalger opened this issue Oct 28, 2019 · 1 comment
Closed

Remove temporary packages/kbn-ui-framework eslint overrides #49541

spalger opened this issue Oct 28, 2019 · 1 comment
Labels

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019

In order to move forward with #49244 we needed to disable some rules in packages/kbn-ui-framework. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['packages/kbn-ui-framework/**/*.{js,ts,tsx}'],
  rules: {
    'jsx-a11y/no-onchange': 'off',
  },
},
@timroes
Copy link
Contributor

timroes commented Nov 18, 2019

Since we're planning to get rid of this as soon as possible, I think we should not spend any effort fixing linting rules here anymore. So I would close this.

@timroes timroes closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants