Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover - Selected Fields not reset with index pattern change #4909

Closed
w33ble opened this issue Sep 9, 2015 · 10 comments
Closed

Discover - Selected Fields not reset with index pattern change #4909

w33ble opened this issue Sep 9, 2015 · 10 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@w33ble
Copy link
Contributor

w33ble commented Sep 9, 2015

In Discover, if you select a field in one index pattern:

screenshot 2015-09-09 15 21 20

Then change index patterns without removing that field, it sticks around in the new index pattern, even when it's not a valid field there:

screenshot 2015-09-09 15 21 11

@w33ble w33ble added bug Fixes for quality problems that affect the customer experience v4.2.0 v4.1.3 labels Sep 9, 2015
@kuy
Copy link

kuy commented Sep 13, 2015

When index patterns are changed, selected fields should be reset by default (savedSearch.columns or ['_source'])? or are there some exceptions?

@cwurm
Copy link
Contributor

cwurm commented Nov 1, 2016

Want to bump this. It still happens in 5.0, and there's no way to remove the selected field without switching back to the index pattern it came from.

There's several options I can think of:

  1. Reset the selected fields when the index pattern is changed (what @kuy suggested)
  2. Remove only the selected fields that are not contained in the newly selected index pattern
  3. Save selected fields for each index pattern (implicitly or explicitly)

Option 3 is a bigger change I guess and needs thinking about the user experience, while 1 or 2 would probably be easier to do.

@cwurm
Copy link
Contributor

cwurm commented Nov 1, 2016

There actually is a button next to the column name, but it's tiny and appears only when hovering over it.

@marius-dr
Copy link
Member

I did encounter this today and my first thought was: "hmm, why are these still here?". It would be nice to have it saved for each index, but for now it still is a bad experience for the user and just resetting it would make a big difference.

@marius-dr
Copy link
Member

Looks the same in 4.x and 5.x, The selected field is not displayed in the upper right list, but it will still be displayed on the dashboard table as a column.

@tbragin
Copy link
Contributor

tbragin commented Feb 6, 2017

Removing discuss label - we will triage this in the context of Discovery team.

@tbragin tbragin removed the discuss label Feb 6, 2017
@weltenwort weltenwort self-assigned this Apr 19, 2017
@weltenwort
Copy link
Member

Is this only limited to the columns? Other parts of the application state that relate to the available fields should probably also be reset when the index pattern changes, i.e. sorting, filters (see #9387), query. How would we justify resetting some but not others?

Discover could absolutely use an overhaul of the way the app state is managed, but then it almost feels like a breaking change instead of a bugfix.

@Bargs
Copy link
Contributor

Bargs commented Apr 21, 2017

@weltenwort I tend to agree, I've left similar comments on other issues. In my mental model the index pattern is just one part of the search, and it should be possible to swap the index pattern without losing the rest of your search. Now that the New button correctly resets the columns, I wonder how useful this would be.

@bluikko
Copy link

bluikko commented Oct 2, 2018

Clicking "New" button before switching the index clears the selected fields... as per #10357

@lukasolson
Copy link
Member

Closing this for now as you can now click the "New" button to clear things out, and some people may want this behavior if they have fields that are the same across index patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests