Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloud][Canvas] Built asset removed in CI build #47405

Closed
clintandrewhall opened this issue Oct 5, 2019 · 5 comments · Fixed by #48567 or #49538
Closed

[cloud][Canvas] Built asset removed in CI build #47405

clintandrewhall opened this issue Oct 5, 2019 · 5 comments · Fixed by #48567 or #49538
Labels
blocker bug Fixes for quality problems that affect the customer experience Team:Cloud v7.5.0 v8.0.0

Comments

@clintandrewhall
Copy link
Contributor

clintandrewhall commented Oct 5, 2019

UPDATE:

I deployed the 7.5.0-SNAPSHOT to a Cloud instance, and the runtime is not present. I downloaded the built artifact and ran it locally: the file is present. It appears as though the Cloud process removes that file from its build of Kibana?


In #46278 I'm building a static runtime, kbn_canvas.js, in canvas/shareable_runtime/build. When I build Kibana locally, using yarn build, the file and its directory are present in the build directory. Further, the file and directory are present in the tar.gz file that results.

Screen Shot 2019-10-04 at 4 13 10 PM

Screen Shot 2019-10-05 at 10 53 01 AM

Yet the build file from CI does not contain that file and directory.

Screen Shot 2019-10-05 at 10 49 06 AM

I assume the CI build is more representative of a production build than my local machine.

  • Is there a build step or process I'm not following to reproduce this locally?
  • Should I be whitelisting this path and file somewhere?
  • Should I rename the directory?
@clintandrewhall clintandrewhall added the Team:Operations Team label for Operations Team label Oct 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@clintandrewhall clintandrewhall changed the title [c][Canvas] Built asset removed in CI build [ci][Canvas] Built asset removed in CI build Oct 5, 2019
@clintandrewhall
Copy link
Contributor Author

@spalger and @mistic helped me out with this -- confirmed fixed in the latest update to the PR. Thanks all!

@clintandrewhall
Copy link
Contributor Author

This was fixed before I merged the PR. I just deployed the 7.5 SNAPSHOT and the runtime is not deployed in Cloud. Open to ideas.

Screen Shot 2019-10-15 at 4 28 12 PM

@clintandrewhall clintandrewhall changed the title [ci][Canvas] Built asset removed in CI build [cloud][Canvas] Built asset removed in CI build Oct 15, 2019
@clintandrewhall clintandrewhall added Team:Cloud bug Fixes for quality problems that affect the customer experience v7.5.0 v8.0.0 and removed Team:Operations Team label for Operations Team labels Oct 15, 2019
@mieciu
Copy link
Contributor

mieciu commented Oct 16, 2019

Just to leave a note after our debugging session with @kobelb . We had to comment out this check
of HapiJS which basically verifies whether kbn_canvas.js exists within confineDir.

If it doesn't (which turned out to be the case) handler.file() in here returns null and as a result 403 is thrown.

This probably indicates a mismatch between configuration of local dev setup and prod one we run in Cloud containers 🙂

@clintandrewhall
Copy link
Contributor Author

#48663 Did not solve the problem. Opening a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience Team:Cloud v7.5.0 v8.0.0
Projects
None yet
3 participants